Add separate overview ruler colors for resolved & unresolved comments#181520
Merged
alexr00 merged 2 commits intomicrosoft:mainfrom May 11, 2023
Merged
Add separate overview ruler colors for resolved & unresolved comments#181520alexr00 merged 2 commits intomicrosoft:mainfrom
alexr00 merged 2 commits intomicrosoft:mainfrom
Conversation
chrmarti
approved these changes
May 9, 2023
alexr00
approved these changes
May 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposal for #156653.
The new colors inherit from
editorGutter.commentRangeForegroundto not break themes that might have set that color with the overview ruler in mind, as it previously affected both locations. EventuallyeditorGutter.commentRangeForegroundshould probably just target the editor gutter as per its name.