Fix: Encode paths as URI components when opening a folder or workspace#182398
Merged
bpasero merged 2 commits intomicrosoft:mainfrom May 15, 2023
Merged
Fix: Encode paths as URI components when opening a folder or workspace#182398bpasero merged 2 commits intomicrosoft:mainfrom
bpasero merged 2 commits intomicrosoft:mainfrom
Conversation
This should prevent issues when trying to open folder paths that contain special characters like `+` or `&`.
Contributor
Author
|
I'm not fully sure how to best add an automated test for this change, can you point me to some existing tests I could extend / use as a starting point? |
bpasero
approved these changes
May 15, 2023
Member
bpasero
left a comment
There was a problem hiding this comment.
Thanks, pushed a 💄 We have no tests in that area.
joaomoreno
approved these changes
May 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #182397
Encode folder paths as URI components, so that special characters like
+are intepreted correctly. This change carves out a special case for/characters, which would be encoded as%2Fto retain more pretty URIs.