Fix contributed profile icons#182615
Conversation
|
@Tyriar You better 👍 ,I learned. |
|
Wait..There are still some issues. |
|
@tisilent oh? It was working when I tested it out? |
| this.shellLaunchConfig.color = defaultProfile.color; | ||
| // Only use default icon and color if they are undefined in the SLC | ||
| this.shellLaunchConfig.icon ??= defaultProfile.icon; | ||
| this.shellLaunchConfig.color ??= defaultProfile.color; |
There was a problem hiding this comment.
@Tyriar The 'New Terminal' action requires default profile.
There was a problem hiding this comment.
Issues:
'New Terminal' using terminal icon, pwsh icon should be used.
After modify, the test is working:
// Only use default icon and color if they are undefined in the SLC if (!this.shellLaunchConfig.isExtensionOwnedTerminal) { this.shellLaunchConfig.icon = defaultProfile.icon; this.shellLaunchConfig.color = defaultProfile.color; } else { this.shellLaunchConfig.icon ??= defaultProfile.icon; this.shellLaunchConfig.color ??= defaultProfile.color; }
I'm not sure if there are better property to distinguish. 😖
Fix #182303 .
The little bug has returned.
