refactor(userDataSync): replace indexOf with includes#182635
Merged
sandy081 merged 1 commit intomicrosoft:mainfrom May 23, 2023
Juneezee:refactor/includes
Merged
refactor(userDataSync): replace indexOf with includes#182635sandy081 merged 1 commit intomicrosoft:mainfrom Juneezee:refactor/includes
indexOf with includes#182635sandy081 merged 1 commit intomicrosoft:mainfrom
Juneezee:refactor/includes
Conversation
This commit replaces the use of `.indexOf` with `.includes` for cases where the method is used to check if an array contains a particular element. This results in improved code readability and better adherence to modern JavaScript best practices. Signed-off-by: Eng Zer Jun <[email protected]>
sandy081
approved these changes
May 23, 2023
Tyriar
approved these changes
May 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello 👋, first-time contributor here.
This PR replaces the use of
.indexOfwith.includesfor cases where the method is used to check if an array contains a particular element. This results in improved code readability and better adherence to modern JavaScript best practices.Closes #182634