Add JSON Lines language definition#183035
Merged
aeschli merged 2 commits intomicrosoft:mainfrom May 25, 2023
DoctorKrolic:add-jsonl-definition
Merged
Add JSON Lines language definition#183035aeschli merged 2 commits intomicrosoft:mainfrom DoctorKrolic:add-jsonl-definition
JSON Lines language definition#183035aeschli merged 2 commits intomicrosoft:mainfrom
DoctorKrolic:add-jsonl-definition
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Contributor
|
Thanks a lot @DoctorKrolic ! Are you also looking at the language support? Otherwise that's something I can tackle. |
alexr00
approved these changes
May 22, 2023
Contributor
Author
Not really. TS isn't my primary language and this doesn't seem to be a trivial thing to do, since even parsing logic would require changes for it to work |
aeschli
approved these changes
May 23, 2023
Contributor
Author
|
CI is green. Merge? |
Contributor
|
Thanks @DoctorKrolic ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #182402
This PR adds
JSON Lineslanguage definition with idjsonl. It doesn't add fancy language features, just basic colorization. But even this makes a great difference when viewing.jsonlfiles.Looks like this:
