fixed tab sizing: restore tab widths when the last tab is closed#183188
fixed tab sizing: restore tab widths when the last tab is closed#183188bpasero merged 3 commits intomicrosoft:mainfrom
Conversation
bpasero
left a comment
There was a problem hiding this comment.
I think this makes sense but what about the index that we pass in here [1], it is probably not the right value? Should we then remove it if we do not have it?
[1]
|
@bpasero The It looks like neither of the two implementors of these methods, Further, the |
|
@jacekkopecky yeah I would think |
Nothing was using the index and beforeCloseEditor could never get anything but undefined anyway.
|
Thank you @bpasero . Nice catch with the |
This is meant to address a forgotten case in #40290 that wasn't addressed in #181729: when the last tab is closed, there is no more reason to hold the tabs at fixed length. This behaviour is consistent with Chrome and Safari.
For illustration, here's a before and after:
(my cursor is huge and the recording software misplaced it, but it was right over the close icons)
cc @bpasero