Fix the case of the breakpoint placeholder#185753
Merged
roblourens merged 3 commits intomicrosoft:mainfrom Jun 30, 2023
abhijit-chikane:breakpoint_placeholder_fix
Merged
Fix the case of the breakpoint placeholder#185753roblourens merged 3 commits intomicrosoft:mainfrom abhijit-chikane:breakpoint_placeholder_fix
roblourens merged 3 commits intomicrosoft:mainfrom
abhijit-chikane:breakpoint_placeholder_fix
Conversation
jrieken
approved these changes
Jun 30, 2023
Member
jrieken
left a comment
jrieken
left a comment
There was a problem hiding this comment.
This fix is legit but I feel this is wrong. Shouldn't we look up the assigned keybindings, like for closeBreakpointWidget and insert that.
Member
|
Yes, that's what it should be doing |
Contributor
Author
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The placeholder of the breakpoint expression input is different for 'Enter' and 'esc'. So I have updated the 'esc' => 'Esc' as that's what how they mention it on keyboard.