Add tabSizingFixedMinWidth setting (#185766)#186058
Merged
bpasero merged 3 commits intomicrosoft:mainfrom Jun 26, 2023
Merged
Conversation
Contributor
Author
|
With a small minimum setting value, normal tabs can get smaller than pinned tabs sized |
bpasero
requested changes
Jun 25, 2023
bpasero
previously approved these changes
Jun 26, 2023
Contributor
Author
|
@bpasero thank you for updating those minima |
alexr00
approved these changes
Jun 26, 2023
bpasero
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simply adds a
tabSizingFixedMinWidthsetting to address the request in #185766.With the minimum being configurable, with diverse users presumably choosing both higher and lower values than the default, there is no longer a reason to have a setting minimum for the
MaxWidth, so I set both to have minimum of 5px, which is the left padding in tabs and in my testing tabs never went any smaller.