Accept a trailing colon in --goto format.#186174
Merged
bpasero merged 2 commits intomicrosoft:mainfrom Jun 30, 2023
Merged
Conversation
This is useful because many tools add a comma after file[:line[:col]].
|
This should also be accepted for code navigation with Ctrl+P. |
bpasero
approved these changes
Jun 30, 2023
chrmarti
approved these changes
Jun 30, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #186173
See #186173 for motivation.
Only the validation code needs modification, as the parsing code already works fine with a trailing colon.