Skip to content

Show placeholder text in testing view progress area (fix #141181)#188484

Merged
connor4312 merged 3 commits intomicrosoft:mainfrom
gjsjohnmurray:fix-141181
Jul 21, 2023
Merged

Show placeholder text in testing view progress area (fix #141181)#188484
connor4312 merged 3 commits intomicrosoft:mainfrom
gjsjohnmurray:fix-141181

Conversation

@gjsjohnmurray
Copy link
Contributor

@gjsjohnmurray gjsjohnmurray commented Jul 21, 2023

This PR fixes #141181

junk

Copy link
Contributor Author

@gjsjohnmurray gjsjohnmurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @connor4312

@connor4312
Copy link
Member

Maybe some text along the lines of "No tests have been run yet" would be nicer? Or maybe we just emit a non-breaking space ('\xA0') to retain the space without showing anything. Having the placeholder there for the sake of being a placeholder feels weird.

@gjsjohnmurray
Copy link
Contributor Author

I agree that a blank placeholder looks better.
junk

@connor4312 connor4312 enabled auto-merge (squash) July 21, 2023 16:53
@connor4312 connor4312 merged commit 723714b into microsoft:main Jul 21, 2023
@gjsjohnmurray gjsjohnmurray deleted the fix-141181 branch July 21, 2023 17:26
@andreamah andreamah added this to the July 2023 milestone Jul 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Test view] [UX]: layout shift when starting tests for the first time.

4 participants