Skip to content

fix: Close #191877, Correct the root path of the saved file#191878

Closed
yiliang114 wants to merge 1 commit intomicrosoft:mainfrom
yiliang114:fix/new-file-path-outof-workspace-folder
Closed

fix: Close #191877, Correct the root path of the saved file#191878
yiliang114 wants to merge 1 commit intomicrosoft:mainfrom
yiliang114:fix/new-file-path-outof-workspace-folder

Conversation

@yiliang114
Copy link
Contributor

@yiliang114 yiliang114 commented Aug 31, 2023

The directory that can be selected at the last level should theoretically be the root directory of the current workspace, but not / (from resource.dirname)

Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR, but this isn't the best fix for #191877. The simple file dialog is used in other places and does allow saving outside the workspace there.

@alexr00 alexr00 closed this Aug 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants