🆒 , is this the change that would enable file watching in all of TS extension with the VS Code file watcher or is there more needed?

is this the change that would enable file watching in all of TS extension with the VS Code file watcher or is there more needed?

Yes microsoft/TypeScript#54662 should redirect all the watch calls by tsserver into vscode if invoked with --canUseWatchEvents

Fyi #194776 landed which enables extensions to do full recursive file watching anywhere even within the workspace with custom exclude rules. It is behind proposed API (createFileSystemWatcher).

@sheetalkamat I pushed a change that gates this feature behind a setting and also tries to clean up file watchers when the server restarts

In my testing, I see errors such as this in the developer tools:

 MainThreadFileSystemEventService#$watch(): failed to stat a resource for file watching (extension: vscode.typescript-language-features, path: file:///Users/matb/projects/node_modules, recursive: true, session: 0.16141590890668556): EntryNotFound (FileSystemError): Error: ENOENT: no such file or directory, stat '/Users/matb/projects/node_modules'

Will this cause any issues for TypeScript? It seems like we may be trying to watch the contents of a directory that does not exist. Will we still pick up if the directory is created later?

Will this cause any issues for TypeScript? It seems like we may be trying to watch the contents of a directory that does not exist. Will we still pick up if the directory is created later?

We do need to watch even if directory does not exist and get events when it gets created. (Without this we wouldnt be picking up changes to project resolutions because of npm install)
@bpasero is this supported. Are the errors because i am yet to add exclude pattern.

@sheetalkamat no, that is not supported. you have to watch a parent folder that exists. Maybe then you will have to watch the workspace folder(s) and do a negated exclude pattern such as !**/node_modules/** to recursively watch any node module folder that is either there already or gets created.