Fix issue with settings not being respected in release notes#205852
Merged
Fix issue with settings not being respected in release notes#205852
Conversation
lszomoru
approved these changes
Feb 21, 2024
yiliang114
pushed a commit
to yiliang114/vscode
that referenced
this pull request
Feb 22, 2024
…ft#205852) Settings with values separated are not respected in release notes Fixes microsoft#205678 Also fixes microsoft#205742
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes an issue where settings with values separated were not being respected in the release notes. The issue was caused by a regex pattern that didn't correctly handle the separation of values. This PR updates the regex pattern to handle the separation of values correctly. Additionally, it adds a new action to copy the setting ID to the clipboard. This will make it easier for users to reference specific settings. Fixes #205678 and #205742.