Skip to content

chore: rm unreached ignore items when build extensions.#227906

Merged
deepak1556 merged 1 commit intomicrosoft:mainfrom
Cecil0o0:Cecil0o0/rm-yarn-lock
Sep 9, 2024
Merged

chore: rm unreached ignore items when build extensions.#227906
deepak1556 merged 1 commit intomicrosoft:mainfrom
Cecil0o0:Cecil0o0/rm-yarn-lock

Conversation

@Cecil0o0
Copy link
Contributor

@Cecil0o0 Cecil0o0 commented Sep 8, 2024

.vscodeignore file used for declaring unused files to ignore when build built-in extensions.

The problem is that after we migrate yarn back to npm, yarn.lock or server/yarn.lock items declared in this file aren't reached actually while building extensions. This pr would like to fix it~

@Cecil0o0 Cecil0o0 changed the title chore: rm unreached ignore items when compiling extensions. chore: rm unreached ignore items when build extensions. Sep 8, 2024
@sandy081 sandy081 assigned deepak1556 and unassigned sandy081 Sep 9, 2024
@sandy081 sandy081 requested a review from deepak1556 September 9, 2024 09:11
Copy link
Collaborator

@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@deepak1556 deepak1556 enabled auto-merge (squash) September 9, 2024 10:10
@deepak1556 deepak1556 added this to the September 2024 milestone Sep 9, 2024
@deepak1556 deepak1556 merged commit 88d7b97 into microsoft:main Sep 9, 2024
@Cecil0o0 Cecil0o0 deleted the Cecil0o0/rm-yarn-lock branch September 9, 2024 13:01
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants