Skip to content

Add letterSpacing to config to address #18715#22979

Merged
alexdima merged 4 commits intomicrosoft:masterfrom
hoovercj:letterSpacing
May 16, 2017
Merged

Add letterSpacing to config to address #18715#22979
alexdima merged 4 commits intomicrosoft:masterfrom
hoovercj:letterSpacing

Conversation

@hoovercj
Copy link
Member

As discussed in #18715, users desire exposing the css letter-spacing property for the editor.

As shown in the below gif, this pack does that by allowing users to set the letter-spacing value in pixels in settings following the pattern of the other font values.

letterspacingdemo

@mention-bot
Copy link

@hoovercj, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima and @egamma to be potential reviewers.

@msftclas
Copy link

@hoovercj,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@hoovercj
Copy link
Member Author

hoovercj commented Apr 7, 2017

Any feedback on this?

@alexdima
Copy link
Member

Looks good! Thank you! ❤️

@alexdima alexdima merged commit dd22831 into microsoft:master May 16, 2017
@alexdima alexdima added this to the May 2017 milestone May 16, 2017
@alexdima alexdima mentioned this pull request May 30, 2017
2 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants