Fixes #944 - Support wildcards on activationEvents.workspaceContains#24570
Conversation
|
@eamodio, thanks for your PR! By analyzing the history of the files in this pull request, we identified @bpasero and @alexandrudima to be potential reviewers. |
c5778ae to
1001192
Compare
|
@alexandrudima I'm not sure why the builds are failing with these changes -- it builds locally. And looking at the travis one, I don't even see any failures. Any ideas? |
1001192 to
10c0610
Compare
|
Apparently it just needed a kick |
|
Any chance this could be looked at in the May iteration? I know the C# extension is really hoping to get this in. |
|
@alexandrudima sorry to bother you, but any feedback on this? |
|
@eamodio Thank you for your contribution! ❤️ |
|
@alexandrudima awesome! thank you! |
|
Thanks, very cool! |
|
Future improvement: This will run until the entire workspace has been searched, even if it finds a match immediately. You could use the progress callback on |
|
@roblourens doesn't this https://github.com/Microsoft/vscode/pull/24570/files#diff-7799696b0b4988cc737acff368fad1b1R140 make it return after the first match? |
|
Oh right, yes :) |
Here is a first pass at this -- I don't really like checking for wildcard/glob characters but it works as is and should be easy enough to change that part if the rest looks reasonable.