#24653 - Adds a new user configuration extensions.ignoreRecommendations - which allows user to enable or disable extension recommendations#25038
Merged
joaomoreno merged 6 commits intomicrosoft:masterfrom May 4, 2017
Conversation
|
@RISHII7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @joaomoreno and @sandy081 to be potential reviewers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a new
USERspace configurationextensions.ignoreRecommendations.When the user clicks on
Do not show againwe show a messageDo you want to ignore all recommendationswith optionsYes, Ignore All,NoandCancelWhen the user chooses
Yes,Ignore All- we add the current extension toextensionAssistant/importantRecommendationsIgnorelist and setextensions.ignoreRecommendationstotrue.When the user chooses
No- we add the current extension toextensionAssistant/importantRecommendationsIgnoreand hide that message.When the user chooses
Cancel- we just hide the current message.In all the cases we record recommendations into
extensionsAssistant/recommendationsbut not alert the user.Even workspace related extension recommendations respect the value of
extensions.ignoreRecommndations.If in case the user does not choose an option for an extension and selects different file type from workspace explorer - which causes stacking up of messages, then selecting
Do not show againand selectingYes, Ignore Allshould not show any recommendations and hide stacked up recommendation messages.