Add .mjs to known JavaScript file extensions#25747
Merged
mjbvz merged 1 commit intomicrosoft:masterfrom May 4, 2017
Merged
Conversation
Also add .es6 in missing places
|
@bmeck, It will cover your contributions to all Microsoft-managed open source projects. |
|
@bmeck, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
Collaborator
|
Thanks! This change should be in the next VSCode insiders build |
aisamu
added a commit
to aisamu/ring
that referenced
this pull request
Aug 8, 2018
Javascript's module system has a suggested `mjs` extension, which has received some degree of adoption (Node [1]), tooling support (Babel [2], VSCode [3]), and is already present on Google's JS Modules documentation [4]. The only requirement is that they're sent with JS's MIME. [1] - http://2ality.com/2017/05/es-module-specifiers.html#why-new-extension [2] - babel/babel#5624 [3] - microsoft/vscode#25747 [4] - https://developers.google.com/web/fundamentals/primers/modules
aisamu
added a commit
to aisamu/ring
that referenced
this pull request
Aug 19, 2018
Javascript's module system has a suggested mjs extension, which has received some degree of adoption (Node [1]), tooling support (Babel [2], VSCode [3]), and is already present on Google's JS Modules documentation [4]. The only requirement is that they're sent with JS's MIME. [1] - http://2ality.com/2017/05/es-module-specifiers.html#why-new-extension [2] - babel/babel#5624 [3] - microsoft/vscode#25747 [4] - https://developers.google.com/web/fundamentals/primers/modules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also add .es6 in missing places