Skip to content

Expose Stickiness API #15758#25776

Merged
alexdima merged 6 commits intomicrosoft:masterfrom
CoenraadS:stickyness_api
May 30, 2017
Merged

Expose Stickiness API #15758#25776
alexdima merged 6 commits intomicrosoft:masterfrom
CoenraadS:stickyness_api

Conversation

@CoenraadS
Copy link
Contributor

@CoenraadS CoenraadS commented May 2, 2017 •
edited
Loading

For issue: #15758

This adds stickiness as a public decoration option.

Use case: I have an extension which colors brackets after a timeout, and I don't want the bracket colors to expand when the user types.

@msftclas
Copy link

msftclas commented May 2, 2017

@CoenraadS,
Thanks for your contribution.
To ensure that the project team has proper rights to use your work, please complete the Contribution License Agreement at https://cla.microsoft.com.

It will cover your contributions to all Microsoft-managed open source projects.
Thanks,
Microsoft Pull Request Bot

@mention-bot
Copy link

mention-bot commented May 2, 2017

@CoenraadS, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jrieken and @egamma to be potential reviewers.

@CoenraadS
Copy link
Contributor Author

CoenraadS commented May 2, 2017 •
edited
Loading

Questions:
TrackedRangeStickiness is now duplicated in vscode.d.ts and editorCommon.ts, but looking at other enums in vscode.d.ts it seems this is standard practise?

@CoenraadS CoenraadS changed the title Expose Stickiness API: https://github.com/Microsoft/vscode/issues/15758 Expose Stickiness API May 2, 2017
@msftclas
Copy link

msftclas commented May 2, 2017

@CoenraadS, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request.

Thanks, Microsoft Pull Request Bot

@CoenraadS CoenraadS changed the title Expose Stickiness API Expose Stickiness API #15758 May 2, 2017
@CoenraadS
Copy link
Contributor Author

CoenraadS commented May 11, 2017 •
edited
Loading

@alexandrudima
Can I get some feedback on this? I searched the editor/test folder for ThemableDecorationRenderOptions and DecorationRenderOptions but didn't find any matches, so if tests are needed I would appreciate some pointers to similar tests which involve using decorations via the API. However this PR mainly just exposes functionality that was already in the codebase.

@alexdima
Copy link
Member

alexdima commented May 29, 2017

@jrieken Any objections?

@alexdima alexdima added this to the May 2017 milestone May 30, 2017
@alexdima alexdima merged commit 54e3d65 into microsoft:master May 30, 2017
@alexdima
Copy link
Member

alexdima commented May 30, 2017

@CoenraadS Thank you for your contribution! ❤️

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@alexdima alexdima

Labels

None yet

Projects

None yet

Milestone

May 2017

Development

Successfully merging this pull request may close these issues.

4 participants

@CoenraadS @msftclas @mention-bot @alexdima