Skip to content

Allow changing a SourceControlResourceGroup's label#25983

Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom
ihalip:scm-resourcegroup-label
May 5, 2017
Merged

Allow changing a SourceControlResourceGroup's label#25983
joaomoreno merged 2 commits intomicrosoft:masterfrom
ihalip:scm-resourcegroup-label

Conversation

@ihalip
Copy link
Contributor

@ihalip ihalip commented May 5, 2017

Currently, it's not possible to change a SourceControlResourceGroup's label once it's created. From vscode.d.ts:

export interface SourceControlResourceGroup {
		readonly id: string;
		readonly label: string; 
                .......

In Perforce, a changelist has a description which can be edited by the user. To refresh that one changelist's description, an extension would have to do changelist.dispose() the existing changelist, and call SourceControl.createResourceGroup() again with the new description. This has a major side effect, because resource groups are re-arranged in the scm viewlet once an existing one is dispose()'d.

This PR makes it possible to change a SourceControlResourceGroup's label without having to call dispose() and createResourceGroup().

@mention-bot
Copy link

@ihalip, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jrieken and @egamma to be potential reviewers.

@ihalip
Copy link
Contributor Author

ihalip commented May 5, 2017

@joaomoreno

@joaomoreno joaomoreno self-requested a review May 5, 2017 06:23
@joaomoreno joaomoreno self-assigned this May 5, 2017
@joaomoreno joaomoreno added this to the May 2017 milestone May 5, 2017
Copy link
Member

@joaomoreno joaomoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

@joaomoreno joaomoreno merged commit 3b6e05e into microsoft:master May 5, 2017
@ihalip ihalip deleted the scm-resourcegroup-label branch May 5, 2017 18:34
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants