Allow changing a SourceControlResourceGroup's label#25983
Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom May 5, 2017
ihalip:scm-resourcegroup-label
Merged
Allow changing a SourceControlResourceGroup's label#25983joaomoreno merged 2 commits intomicrosoft:masterfrom ihalip:scm-resourcegroup-label
joaomoreno merged 2 commits intomicrosoft:masterfrom
ihalip:scm-resourcegroup-label
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, it's not possible to change a SourceControlResourceGroup's label once it's created. From vscode.d.ts:
In Perforce, a changelist has a description which can be edited by the user. To refresh that one changelist's description, an extension would have to do
changelist.dispose()the existing changelist, and callSourceControl.createResourceGroup()again with the new description. This has a major side effect, because resource groups are re-arranged in the scm viewlet once an existing one is dispose()'d.This PR makes it possible to change a SourceControlResourceGroup's label without having to call
dispose()andcreateResourceGroup().