Fix php function highlight#26543
Fix php function highlight#26543luxifer wants to merge 2 commits intomicrosoft:masterfrom luxifer:fix-php-function-highlight
Conversation
According to http://php.net/manual/en/functions.user-defined.php extended ascii is allowed in function name such as non breaking space ( )
|
@luxifer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima to be a potential reviewer. |
|
@luxifer, It will cover your contributions to all Microsoft-managed open source projects. |
|
@luxifer, thanks for signing the contribution license agreement. We will now validate the agreement and then the pull request. |
|
Thanks @luxifer! |
|
If you want, when you have updated the grammar I can submit another PR with only the tests to ensure the new grammar works |
|
@aeschli the PR on atom has been merged |
|
@luxifer I updated the grammar. Thanks a lot! |
|
I guess it will be part of the may 2017 release?
Le 18 mai 2017 11:12 AM, "Martin Aeschlimann" <[email protected]> a
écrit :
… @luxifer <https://github.com/luxifer> I updated the grammar. Thanks a lot!
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26543 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZlBqY-WUeG6OSb-vt_WLMX0dbLn9n5ks5r7AuOgaJpZM4NZFsW>
.
|
|
@luxifer Yes |
|
Here's the pull request with only the tests #26992 |
4 participants
According to http://php.net/manual/en/functions.user-defined.php extended ascii is allowed in function name such as non breaking space