Fix lua function colorizing error#26880
Closed
actboy168 wants to merge 1 commit intomicrosoft:masterfrom
actboy168:master
Closed
Fix lua function colorizing error#26880actboy168 wants to merge 1 commit intomicrosoft:masterfrom actboy168:master
actboy168 wants to merge 1 commit intomicrosoft:masterfrom
actboy168:master
Conversation
e.g. ```lua function mt:x(a, b) end function mt1:x(a, b) end function(a, b) end function (a, b) end ```
|
This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. We will now review your pull request. |
Contributor
|
We use the grammar from https://github.com/textmate/lua.tmbundle. Would you mind also create a PR there? |
Author
|
Do you mean that textmate/lua.tmbundle#7 ? It looks like this is a nobody to maintain the project. |
Contributor
|
textmate/lua.tmbundle#7 has been fixed and I update the lua grammar in VSCode. I verified your example works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
After
