Skip to content

Add more tests to PHP grammar#26992

Merged
aeschli merged 2 commits intomicrosoft:masterfrom
luxifer:php-language-tests
May 22, 2017
Merged

Add more tests to PHP grammar#26992
aeschli merged 2 commits intomicrosoft:masterfrom
luxifer:php-language-tests

Conversation

@luxifer
Copy link
Contributor

@luxifer luxifer commented May 20, 2017

Related to #26543 I added the tests to validate the new backported grammar from atom/language-php#196

@mention-bot
Copy link

@luxifer, thanks for your PR! By analyzing the history of the files in this pull request, we identified @alexandrudima to be a potential reviewer.

@msftclas
Copy link

@luxifer,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by Microsoft. We will now review your pull request.
Thanks,
Microsoft Pull Request Bot

@aeschli aeschli merged commit 764dab3 into microsoft:master May 22, 2017
@aeschli
Copy link
Contributor

aeschli commented May 22, 2017

Thanks @luxifer !

@aeschli aeschli added this to the May 2017 milestone May 22, 2017
@aeschli aeschli added the php PHP support issues label May 22, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

php PHP support issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants