Skip to content

Fixed SCM Badge Issue #42940#43256

Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom
pushqrdx:master
Jul 6, 2018
Merged

Fixed SCM Badge Issue #42940#43256
joaomoreno merged 1 commit intomicrosoft:masterfrom
pushqrdx:master

Conversation

@pushqrdx
Copy link
Contributor

@pushqrdx pushqrdx commented Feb 8, 2018

I have tested this out on my machine and it appears to work fine.

I have tested this out on my machine and it appears to work fine.
@pushqrdx
Copy link
Contributor Author

pushqrdx commented Feb 9, 2018

@shobhitchittora line-height equals to height helps vertically align numbers, while the display prop is for height, width to be actually effective. also changing padding will result in a non circular badge for numbers less than 10 which will still look strange.

@shobhitchittora
Copy link
Contributor

LGTM.
@joaomoreno please review and close this.

@joaomoreno joaomoreno self-assigned this Feb 12, 2018
@joaomoreno joaomoreno added this to the February 2018 milestone Feb 12, 2018
@joaomoreno joaomoreno added the scm General SCM compound issues label Feb 12, 2018
@shobhitchittora
Copy link
Contributor

Ping @joaomoreno.

@joaomoreno joaomoreno modified the milestones: February 2018, March 2018 Feb 26, 2018
@bpasero bpasero modified the milestones: March 2018, April 2018 Apr 6, 2018
@joaomoreno joaomoreno modified the milestones: April 2018, Backlog Apr 23, 2018
@paulbremer
Copy link

There are bad whitespace indentation errors during the build;
src/vs/base/browser/ui/countBadge/countBadge.css(10,1): Bad whitespace indentation src/vs/base/browser/ui/countBadge/countBadge.css(11,1): Bad whitespace indentation

@shobhitchittora
Copy link
Contributor

@pushqrdx Would you be so kind and fix the CI issues. Also please make sure to run the test before every commit / raising a PR. Doc link - https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines

@joaomoreno joaomoreno closed this May 2, 2018
@joaomoreno joaomoreno reopened this May 2, 2018
@joaomoreno joaomoreno closed this May 3, 2018
@joaomoreno joaomoreno reopened this May 3, 2018
@pushqrdx
Copy link
Contributor Author

pushqrdx commented May 5, 2018

@shobhitchittora alright, i'll, gladly, do so asap, Sorry for the delay i am on a trip out of town.

@joaomoreno
Copy link
Member

Thanks! 🍻

@joaomoreno joaomoreno merged commit fc0c204 into microsoft:master Jul 6, 2018
@joaomoreno joaomoreno modified the milestones: Backlog, July 2018 Jul 6, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

scm General SCM compound issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants