Support for updating extensions from CLI#45533
Support for updating extensions from CLI#45533sandy081 merged 3 commits intomicrosoft:masterfrom oriash93:oriash93/45072
Conversation
|
Isn't this missing the addition of a |
|
@tomzx actually I meant to enable updating installed extensions under the same roof as installing. |
|
@oriash93 Right. As per @joaomoreno's comment in #45072, adding an alias (such as This however points to issues:
|
|
@tomzx you made good points.
However, it's not my decision to make :) |
src/vs/code/node/cliProcessMain.ts
Outdated
There was a problem hiding this comment.
There is a check to early quit at line 117 if an extension is already installed. That check should be removed.
src/vs/code/node/cliProcessMain.ts
Outdated
There was a problem hiding this comment.
This might also downgrade the extension. You should check if there is a newer version of extension in the market place. For eg here
| return TPromise.wrapError(new Error(`${notFound(id)}\n${useId}`)); | ||
| } | ||
|
|
||
| console.log(localize('foundExtension', "Found '{0}' in the marketplace.", id)); |
There was a problem hiding this comment.
What happens if the extension is not installed. I assume it will throw an exception now as it is not being checked.
There are three flows:
- Extension is not installed
- Extension is installed but update required
- Extension is installed and no update required.
I do not see where the first case is handled here
|
@oriash93 Changes look good. But before merging, please test if the changes are working and not breaking any other scenarios and let me know. Thanks |
|
@oriash93 Were you able to test if it works? |
|
I meant to, but didn't get to :( |
|
Have to wait until you test it for merging. |
4 participants
resolves #45072