implement push success notification for issue #39039#47790
Merged
joaomoreno merged 1 commit intomicrosoft:masterfrom Jul 6, 2018
Merged
implement push success notification for issue #39039#47790joaomoreno merged 1 commit intomicrosoft:masterfrom
joaomoreno merged 1 commit intomicrosoft:masterfrom
Conversation
Member
|
Thanks! 🍻 |
|
It's great! Much appreciated (#39039) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My friend (@ylingene) and I worked on issue #39039. We didn't implement anything to show if the push failed because error messages already show on failure.
Test plan:
Set git.showPushSuccessNotification to true in settings
Make changes to file, commit the file, and push
Delete git.showPushSuccessNotification from settings (default value is false, as shown in step 1 screenshot)
Make changes to file, commit the file, and push (no notification)
Change file in remote to cause merge conflict
Set git.showPushSuccessNotification to true in settings, make changes to file, commit the file, and push (no notification)
