Add branch name validation and whitespace config#50712
Merged
joaomoreno merged 2 commits intomicrosoft:masterfrom Sep 13, 2018
raix:feature/50241-Add_branch_name_validation
Merged
Add branch name validation and whitespace config#50712joaomoreno merged 2 commits intomicrosoft:masterfrom raix:feature/50241-Add_branch_name_validation
joaomoreno merged 2 commits intomicrosoft:masterfrom
raix:feature/50241-Add_branch_name_validation
Conversation
* Adds `git.createBranchNameConvention.regexp` * Adds `git.createBranchWhitespaceChar` Fixes #50241
sommai232323
approved these changes
May 29, 2018
Contributor
Author
|
@joaomoreno is it possible to run this build again? I think to remember it failed installing npm modules. |
Member
|
@raix Let's merge master into it first, then a new build will be triggered. |
…d_branch_name_validation * Microsoft/master: (4802 commits) Fixes #57415: autoSurround - rename "always" to "languageDefined" debug: skip over %0 explorer view: cut down delay time till progress from 3.2s to 1.2s file workspace suffix is empty string Revert "debug: do not send terminate to EH debugging" Fixes #57411: Rename `autoWrapping` to `autoSurround` to avoid confusions related to text wrapping Fixes #57453: Avoid thinking the user typed in the find input when setting the search string value Synchronisation notification: - Show extension being synchronised - Delete the downloaded extensions [html] fix tests debug: do not send terminate to EH debugging webpack - let build fail when webpack generates an error or a warning [html] update service. Fixes #57445 [email protected] more complete fix for #57483 fix #57351 fix #57483 fixes #56015 dispose of RunOnceScheduler properly Fixes microsoft/monaco-editor#1021: Use ProviderResult in modes.ts fix #55607 ...
Member
|
Thanks! 🍻 Did a few changes to the settings names. |
Contributor
Author
|
Thanks @joaomoreno sounds good 👍 |
raix
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds following options to the
gitextension.git.createBranchNameConvention.regexpgit.createBranchWhitespaceCharPreview:
This is an initial pr. with the implementation for further discussion, if this is something the vscode team would consider.
eg. if the change should enable extensions to lint/validate the branch name or be a configuration etc.
Fixes #50241
Preview of alternative: Adding an extension api, searching tickets not fixed - also write the branch name after whitespaces etc. have been replaced:
