Skip to content

Implement smooth caret animation with toggleable setting#51197

Merged
alexdima merged 2 commits intomicrosoft:masterfrom
JeffreyCA:smooth-caret-animation
Nov 2, 2018
Merged

Implement smooth caret animation with toggleable setting#51197
alexdima merged 2 commits intomicrosoft:masterfrom
JeffreyCA:smooth-caret-animation

Conversation

@JeffreyCA
Copy link
Member

Addresses #20310

This Pull Request implements the option for having a smooth caret animation while typing, moving the cursor, and selecting text. It is very similar to the animation in Office 2013 and 2016 products.

This feature request was gaining some traction over the last couple of weeks, and today several people suggested how it could be implemented via a change in the CSS. This implementation is based on @incognitojam's suggestion here.

@msftclas
Copy link

msftclas commented Jun 6, 2018

CLA assistant check
All CLA requirements met.

@JeffreyCA
Copy link
Member Author

Any updates? @alexandrudima

@JeffreyCA
Copy link
Member Author

@aeschli @alexandrudima any comments on this? It's been 2 months.

@JeffreyCA JeffreyCA force-pushed the smooth-caret-animation branch from 0fb92cb to 8d664e4 Compare August 10, 2018 13:03
@alexdima
Copy link
Member

alexdima commented Nov 2, 2018

Works great! Thank you!

@alexdima alexdima added this to the November 2018 milestone Nov 2, 2018
@alexdima alexdima merged commit 1f9ec65 into microsoft:master Nov 2, 2018
@JeffreyCA
Copy link
Member Author

Finally! Thanks for merging it in! 😃

@rainerklier
Copy link

cool!

@JeffreyCA
Copy link
Member Author

There's a small issue where after you toggle the setting, when you switch back to an editor tab the changes do not get applied immediately. I had to switch between two different tabs before the settings applied.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants