Fix a double dash in the previewer if an @param jsdoc tag has a hyphen after the param name#53365
Merged
mjbvz merged 4 commits intomicrosoft:masterfrom Jul 6, 2018
Merged
Fix a double dash in the previewer if an @param jsdoc tag has a hyphen after the param name#53365mjbvz merged 4 commits intomicrosoft:masterfrom
mjbvz merged 4 commits intomicrosoft:masterfrom
Conversation
Member
|
Is there an issue for this? |
Contributor
Author
|
#2387, maybe, but that's been closed. |
Collaborator
|
@coolreader18 Please create a new issue to tie this PR to. Also add a simple test case in https://github.com/Microsoft/vscode/blob/master/extensions/typescript-language-features/src/test/jsdocSnippet.test.ts You can run this test using the |
Collaborator
|
Can you also please add a simple test case for this |
|
|
Collaborator
|
Thanks! This change will be in the next VS Code insiders build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some screenshots of the problem. The WIP tsdoc spec allows a hyphen after the param name, and I believe jsdoc does as well. This would cause a double dash if the description was a single line (— -), and a bullet point if it were multiple lines because of markdown.
Resolves #53507.