Added ability to output extension info to clipboard#54433
Closed
lannonbr wants to merge 707 commits intomicrosoft:masterfrom
lannonbr:extension-info-action
Closed
Added ability to output extension info to clipboard#54433lannonbr wants to merge 707 commits intomicrosoft:masterfrom lannonbr:extension-info-action
lannonbr wants to merge 707 commits intomicrosoft:masterfrom
lannonbr:extension-info-action
Conversation
sandy081
requested review from
ramya-rao-a and
sandy081
and removed request for
sandy081
Makes sure webviews don't show up in the history quick pick. We already do this filtering properly when there is a query, just not when there is no query
* Support tags on settings to filter in settings editor * Revert adding tags to api until we are ready
Make sure we always invoke the applyCodeActionCommand. This is needed for telemetry to be sent properly
Same reasons as [here](silvenon/vscode-mdx#6 (comment))
Try to normalize file cases on case-insensitive file systems
Avoids registering class on unsupported ts versions
- Avoids extra checks when response cannot be null
…-icon Show the "method" icon for constructors
ramya-rao-a
reviewed
Jul 31, 2018
| export class ExtensionInfoAction extends Action implements IExtensionAction { | ||
|
|
||
| static readonly ID = 'extensions.extensionInfo'; | ||
| static LABEL = localize('extensionInfoAction', "Copy Extension info to clipboard"); |
Contributor
There was a problem hiding this comment.
The to clipboard here is unnecessary. We have other copy actions in the product where it is assumed that the user knows that the text is copied to clipboard.
How about Copy Extension information?
ramya-rao-a
reviewed
Jul 31, 2018
| const clipboardStr = `${localizedExtension}\n${localizedDescription}\n${localizedVersion}\n${localizedPublisher}\n${localizedVSMarketplaceLink}`; | ||
|
|
||
| clipboard.writeText(clipboardStr); | ||
| this.notificationService.info(localize('extensionInfoActionNotification', 'Extension info copied to clipboard')); |
Contributor
There was a problem hiding this comment.
To stay consistent with other copy actions in the product that do not show any notifications on copy (For eg: Copy Path), let's skip the notification here.
…turbs -webkit-line-clamp for some reason
* Dont show existing filters in autocomplete * Simplify
…tInFiles can respect isWordMatch correctly
…scode into extension-info-action
Contributor
|
@lannonbr This PR is currently in a very bad state most probably due to a bad merge from master. I'll close this PR. Can you create a new one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
19 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements #47296
I added an action to the extensions actions cog to copy a chunk of metadata from an extension to the clipboard.
The copied text includes: id, description, version, publisher, and marketplace link.
This also could be useful so if a user has a bug with an extension, they could copy this into an issue and the extension maintainer could know some metadata like the extension version when they're trying to debug an issue.