Skip to content

Support tags on settings to filter in settings editor#55094

Merged
ramya-rao-a merged 2 commits intomasterfrom
ramyar/settings-tags
Jul 25, 2018
Merged

Support tags on settings to filter in settings editor#55094
ramya-rao-a merged 2 commits intomasterfrom
ramyar/settings-tags

Conversation

@ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Jul 25, 2018

To support a separate viewing of settings that control background online features (as described in #54354), this PR adds tags to settings

cc @sandy081

@ramya-rao-a ramya-rao-a requested a review from roblourens July 25, 2018 21:13
@ramya-rao-a ramya-rao-a self-assigned this Jul 25, 2018
@roblourens
Copy link
Member

Do we want to add it to configurationExtensionPoint.ts yet? I think that's essentially extension API, we could leave out so it's a hidden property for builtin extensions until we're sure we like the shape.

@ramya-rao-a
Copy link
Contributor Author

@roblourens I agree. I've removed the change to configurationExtensionPoint.ts

@ramya-rao-a ramya-rao-a merged commit d8bf144 into master Jul 25, 2018
@ramya-rao-a ramya-rao-a deleted the ramyar/settings-tags branch July 25, 2018 22:54
@sandy081
Copy link
Member

What are the other tags that can be supported and how can this be leveraged as an end user?

@ramya-rao-a
Copy link
Contributor Author

What are the other tags that can be supported

Tags can be literally anything. We will support tag based search just like we do for extensions.

how can this be leveraged as an end user

Any kind of filtering that goes across the existing groups that you see in the toc and which cannot be easily achieved by text search are the best use cases for tags. No bright ideas at the moment as to what other examples for tags.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants