Add option to enable cycling of parameter hints#55354
Merged
jrieken merged 2 commits intomicrosoft:masterfrom Aug 7, 2018
Merged
Add option to enable cycling of parameter hints#55354jrieken merged 2 commits intomicrosoft:masterfrom
jrieken merged 2 commits intomicrosoft:masterfrom
Conversation
jrieken
reviewed
Aug 6, 2018
| 'default': EDITOR_DEFAULTS.contribInfo.codeLens, | ||
| 'description': nls.localize('codeLens', "Controls whether the editor shows CodeLens") | ||
| }, | ||
| 'editor.cycleParameterHints': { |
Member
There was a problem hiding this comment.
Hm, maybe a better name which puts parameter hints first. My preference would be editor.parameterHints.cycle but that would require a refactoring of the existing editor.parameterHints setting, e.g. into editor.parameterHints.enabled.
Contributor
Author
There was a problem hiding this comment.
Ok, I've refactored the settings as such in my latest commit.
jrieken
added
feature-request
Member
|
lgtm. Thanks @ozyx! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54726 by adding an option (default:
false) to cycle through parameter hints instead of closing the autocomplete dialog when reaching the end of the list.I'm just beginning to get some experience with the VSCode codebase, so my choice of words in describing the action of this new option may not be ideal. Also, I put the option under "text editor" options-- if there is a better place for it, please let me know.