Hide the feedback form after clicking Submit a bug#55938
Merged
RMacfarlane merged 4 commits intomicrosoft:masterfrom Aug 22, 2018
Merged
Hide the feedback form after clicking Submit a bug#55938RMacfarlane merged 4 commits intomicrosoft:masterfrom
RMacfarlane merged 4 commits intomicrosoft:masterfrom
Conversation
RMacfarlane
reviewed
Aug 13, 2018
| .on('click', event => { | ||
| dom.EventHelper.stop(event); | ||
| if(!!this.requestFeatureLink){ | ||
| shell.openExternal(this.requestFeatureLink); |
Contributor
There was a problem hiding this comment.
This looks good!
I think it would be simpler to keep the 'href' as this.requestFeatureLink above, and then the on click could just have this.hide() and let the event bubble.
Contributor
Author
There was a problem hiding this comment.
That's a really good point. I'll rework this tomorrow to use that approach.
Contributor
Author
|
@RMacfarlane updated the PR with your idea of just letting the event bubble after hiding. |
Contributor
|
Pushed one small change to remove an unused import. This looks good to me, thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #55713