override Ubuntu's default integrated terminal font options (#35901)#56429
Merged
Tyriar merged 2 commits intomicrosoft:masterfrom Sep 20, 2018
Merged
override Ubuntu's default integrated terminal font options (#35901)#56429Tyriar merged 2 commits intomicrosoft:masterfrom
Tyriar merged 2 commits intomicrosoft:masterfrom
Conversation
andyli
force-pushed
the
ubuntu_font
branch
3 times, most recently
from
dbd0743 to
b4738c9
Compare
andyli
force-pushed
the
ubuntu_font
branch
2 times, most recently
from
13eded3 to
5405327
Compare
ctrlaltvikas
approved these changes
Aug 16, 2018
Contributor
Author
|
Is there any problem with this PR? |
|
Minor "bug" arising from this: zsh's (and similar shells) powerline fonts no longer work by default. |
4 tasks
Tyriar
added a commit
that referenced
this pull request
Oct 11, 2018
Member
|
@jhpratt they should still work, you just need to set the font (try setting terminal.integrated.fontFamily instead of editor.fontFamily?) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #56311 (comment).