Fix #55723 - Show appropriate error message when extension gallery service is not accessible#56767
Merged
ramya-rao-a merged 1 commit intomicrosoft:masterfrom Aug 21, 2018
Merged
Conversation
ramya-rao-a
approved these changes
Aug 20, 2018
Contributor
|
@jats22 Thanks for the PR. Unfortunately, we dont have unit tests around that area at the moment, but we definitely need some. Let me know if you plan to add any tests. If yes, then I'll wait for that else, merge this PR right away. |
Contributor
Author
|
No problem. Unfortunately I am new to this project and I would rather wait to write a good test when I have a better understanding of it. So please merge it and I could contribute a well written unit test later. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This closes #55723 by replacing the await calls to normal promise call such that any errors are bubbled up.
@ramya-rao-a also I was wondering if a unit test for the scenario should be added?