Skip to content

Fix for #47852#56775

Merged
isidorn merged 1 commit intomicrosoft:masterfrom
jeanp413:fix47852
Aug 28, 2018
Merged

Fix for #47852#56775
isidorn merged 1 commit intomicrosoft:masterfrom
jeanp413:fix47852

Conversation

@jeanp413
Copy link
Contributor

Fixes issue #47852

@isidorn
Copy link
Collaborator

isidorn commented Aug 20, 2018

Thanks for the fix. But I'll be honest with you this looks like too much complication for an issue that only one user has hit and which looks like a corner case.
I appologise but I will not accept this right away as I fear this might cause some unrelated issues.
For now leaving this open.

@isidorn isidorn added this to the Backlog milestone Aug 20, 2018
@jeanp413
Copy link
Contributor Author

Ok @isidorn I understand.
Just for the record the fix for the issue is in essence just this line.
The other changes I made are needed to fix a bug (that I discover while testing and it's somewhat related) which is when you try to move multiple root folders and one of those is an ancestor of the others and it ends up just moving the parent folder due to the call to the function resources.distinctParents.

@isidorn
Copy link
Collaborator

isidorn commented Aug 21, 2018

If that line is enough to fix the issue than I recommend to create a simple one line pr with only that change.
The second issue we can tackle independently

@jeanp413
Copy link
Contributor Author

jeanp413 commented Aug 22, 2018

@isidorn I updated the PR containing just the one line fix for the issue.
Should I create a new issue for the other bug that I described?

@isidorn
Copy link
Collaborator

isidorn commented Aug 22, 2018

@jeanp413 the PR looks good now. Did you test this PR out, does it fix the issue? Does drag and droping the workspace roots in regular cases work as expected?
Feel free to create a new issue for the bug you described

@jeanp413
Copy link
Contributor Author

jeanp413 commented Aug 23, 2018

@isidorn yes, it works.
after
Also created the issue #57057 for the other bug that I described.

@jeanp413
Copy link
Contributor Author

ping @isidorn

@isidorn
Copy link
Collaborator

isidorn commented Aug 28, 2018

@jeanp413 thanks for the PR and sorry for the slow response

@isidorn isidorn merged commit 72ff01b into microsoft:master Aug 28, 2018
@isidorn isidorn modified the milestones: Backlog, August 2018 Aug 28, 2018
@jeanp413 jeanp413 deleted the fix47852 branch August 29, 2018 02:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants