Closed
Conversation
This fixes a crash on Linux systems running Glibc 2.28 (see electron/electron#13972)
|
|
Author
|
Also, this might be worth backporting to stable, but I'd leave that decision up to the maintainers. |
Member
|
VSCode is using a custom Electron build for the official releases and we have not yet updated that to 2.0.8 because we are waiting for a possible 2.0.9 release that includes more changes we want. We cannot accept this PR until we have done these updates to our build. |
|
I'm waiting on this PR since I can't use code. @K900 can you pass me the build? |
Member
|
I am closing this, we want to pick up 2.0.9 when its out. This should happen during this month 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a crash on Linux systems running Glibc 2.28 (see electron/electron#13972, #55934 etc.). All the tests pass, and no more crashes on Arch Linux, even with the offending glibc patch un-reverted.