styles for diff on markdown preview#59289
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Sep 25, 2018
agurod42:vscode-59288
Merged
styles for diff on markdown preview#59289mjbvz merged 2 commits intomicrosoft:masterfrom agurod42:vscode-59288
mjbvz merged 2 commits intomicrosoft:masterfrom
agurod42:vscode-59288
Conversation
agurod42
commented
Sep 25, 2018
| } | ||
|
|
||
| code span.hljs-addition { | ||
| background: var(--vscode-diffEditor-insertedTextBackground, rgba(155, 185, 85, 0.2)); |
Contributor
Author
There was a problem hiding this comment.
This default color was picked up from here: https://github.com/Microsoft/vscode/blob/d9add550e9315d133484f5497362a830a71da29a/src/vs/platform/theme/common/colorRegistry.ts#L292
agurod42
commented
Sep 25, 2018
| } | ||
|
|
||
| code span.hljs-deletion { | ||
| background: var(--vscode-diffEditor-removedTextBackground, rgba(255, 0, 0, 0.2)); |
Contributor
Author
There was a problem hiding this comment.
This color was picked up from here:
mjbvz
requested changes
Sep 25, 2018
Collaborator
mjbvz
left a comment
mjbvz
left a comment
There was a problem hiding this comment.
Thanks for the fix. The new css looks good but please move these into the markdown specific css file: /extensions/markdown-language-features/media/highlight.css
Collaborator
|
Awesome! This change will be in the next vs code insiders build and will go to stable in 1.28 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59288