Show README instead of welcome page, if it exists#60061
Merged
chrmarti merged 3 commits intomicrosoft:masterfrom Nov 6, 2018
iamnapo:welcome-readme
Merged
Show README instead of welcome page, if it exists#60061chrmarti merged 3 commits intomicrosoft:masterfrom iamnapo:welcome-readme
chrmarti merged 3 commits intomicrosoft:masterfrom
iamnapo:welcome-readme
Conversation
|
|
chrmarti
reviewed
Oct 9, 2018
Collaborator
chrmarti
left a comment
chrmarti
left a comment
There was a problem hiding this comment.
Thanks for working on this. Please see my comments.
src/vs/workbench/parts/welcome/page/electron-browser/welcomePage.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/parts/welcome/page/electron-browser/welcomePage.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/parts/welcome/page/electron-browser/welcomePage.ts
Outdated
Show resolved
Hide resolved
src/vs/workbench/parts/welcome/page/electron-browser/welcomePage.contribution.ts
Outdated
Show resolved
Hide resolved
|
@iamnapo I would love to help out in any way, let me know how we can coordinate :) |
Contributor
Author
|
@jaywick Thanks! I think I figured everything out, but if you have any suggestions on code refactoring, LMK |
iamnapo
changed the title
Collaborator
|
Just missing handling of |
|
Thanks for implementing! |
|
Just opened a project I hadn't worked on for a while and the README popped up right into my face. I promise I won't spam anymore, but I just wanted to let you know how much I appreciate this feature :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31450