Skip to content

fix issue #46816#60404

Merged
chrmarti merged 2 commits intomicrosoft:masterfrom
greybax:fix-issue-46816
Nov 6, 2018
Merged

fix issue #46816#60404
chrmarti merged 2 commits intomicrosoft:masterfrom
greybax:fix-issue-46816

Conversation

@greybax
Copy link
Contributor

@greybax greybax commented Oct 9, 2018

No description provided.

@chrmarti chrmarti added this to the October 2018 milestone Oct 12, 2018
@chrmarti
Copy link
Collaborator

Thanks for your contribution! Using Solarize Light suggests that the background should be set on .welcomePageContainer and that the default should be null, so the regular editor background is used:

image

Could you update the PR with these changes?

@chrmarti chrmarti removed this from the October 2018 milestone Oct 24, 2018
@greybax
Copy link
Contributor Author

greybax commented Oct 26, 2018

yes, sure. Will do now

@chrmarti chrmarti modified the milestones: October 2018, November 2018 Oct 29, 2018
@chrmarti chrmarti merged commit 6eb24fb into microsoft:master Nov 6, 2018
@chrmarti
Copy link
Collaborator

chrmarti commented Nov 6, 2018

Thanks @greybax !

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants