Add an entry to the search history when the search is triggered by an option change#61993
Merged
roblourens merged 4 commits intomicrosoft:masterfrom Nov 12, 2018
Conversation
was triggered by an option change
Member
|
This looks great but it makes me realize that we have the same problem in another case - when the user presses enter in the "files to include/exclude" box, it also doesn't save the history. Maybe we should call addToHistory from onQueryChanged? |
Contributor
Author
|
that might be the best solution because that way we can be sure that the history is saved every time a search is done. i will give it a try to see how it works. |
Member
|
Are you still looking at this @iBlackShadow? |
Contributor
Author
|
Yeah, i have been a little busy but i want to fix this this weekend. |
|
|
roblourens
approved these changes
Nov 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #61346