fix #62112 - merge overlapping delete operations#62667
Merged
alexdima merged 2 commits intomicrosoft:masterfrom Nov 10, 2018
Merged
fix #62112 - merge overlapping delete operations#62667alexdima merged 2 commits intomicrosoft:masterfrom
alexdima merged 2 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
I could write unit tests for the function _getLinesToRemove if that's advisable. If I do I think it would be better for the signature to be _getLinesToRemove(selections: Selection[]) so that we don't have to mock the editor. Please tell me if I should do that and if yes if I should add it to this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are more details at the issue #62112 page