Skip to content

Fix #62785 empty lines in debug console copyAll#62823

Merged
isidorn merged 1 commit intomicrosoft:masterfrom
leonm1:master
Nov 9, 2018
Merged

Fix #62785 empty lines in debug console copyAll#62823
isidorn merged 1 commit intomicrosoft:masterfrom
leonm1:master

Conversation

@leonm1
Copy link
Contributor

@leonm1 leonm1 commented Nov 9, 2018 •
edited
Loading

Example outputs

Fixes #62785 - Copy All action in debug terminal inserts extra lines in between output

Prior to change


C:\Program Files\nodejs\node.exe --inspect-brk=32511 binSearch.js 
Debugger listening on ws://127.0.0.1:32511/6309b5be-dae5-424f-9065-ba2b8af0a4d0

Debugger attached.

c:\Users\matth\Desktop\binSearch.js:5

const binarySearch = (tar, nums) => {

                     ^



RangeError: Maximum call stack size exceeded

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:5:22)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

Waiting for the debugger to disconnect...

RangeError: Maximum call stack size exceeded
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:5:22)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

After change


C:\Program Files\nodejs\node.exe --inspect-brk=3546 binSearch.js
Debugger listening on ws://127.0.0.1:3546/f4a816f9-e0bb-43f9-be24-7e36e30ee971
Debugger attached.
c:\Users\matth\Desktop\binSearch.js:5
const binarySearch = (tar, nums) => {
                     ^

RangeError: Maximum call stack size exceeded
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:5:22)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
Waiting for the debugger to disconnect...
RangeError: Maximum call stack size exceeded
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:5:22)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)
    at binarySearch (c:\Users\matth\Desktop\binSearch.js:21:12)

Tested with master branch on both Windows 10 and ArchLinux.

@isidorn isidorn added this to the November 2018 milestone Nov 9, 2018
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label Nov 9, 2018
@isidorn isidorn merged commit f637774 into microsoft:master Nov 9, 2018
@isidorn
Copy link
Collaborator

isidorn commented Nov 9, 2018

@leonm1 thanks a lot for your nice PR

@mkenigs mkenigs mentioned this pull request Nov 9, 2018
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@isidorn isidorn

Labels

debug Debug viewlet, configurations, breakpoints, adapter issues

Projects

None yet

Milestone

November 2018

Development

Successfully merging this pull request may close these issues.

Copy action in debug console is inserting empty lines between each line

2 participants

@leonm1 @isidorn