Strict null checks for keyboardMapperTestUtils#63027
Merged
alexdima merged 2 commits intomicrosoft:masterfrom Nov 13, 2018
Logerfo:master
Merged
Strict null checks for keyboardMapperTestUtils#63027alexdima merged 2 commits intomicrosoft:masterfrom Logerfo:master
alexdima merged 2 commits intomicrosoft:masterfrom
Logerfo:master
Conversation
|
|
Contributor
Author
|
I don't think that the build failure is my fault. I got some errors even before making any changes, so I ignored them. |
Member
|
LGTM |
Contributor
Author
|
@mjbvz don't forget to mark it as done at #60565 (comment), preventing other people to do the same work ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first contribution to this repo, I'm keeping it short to make sure I'm on the right path.
#60565
@mjbvz