Fix #62365 : Added useGlobalStorageForSuggestions Setting#63193
Merged
jrieken merged 2 commits intomicrosoft:masterfrom Dec 3, 2018
Merged
Fix #62365 : Added useGlobalStorageForSuggestions Setting#63193jrieken merged 2 commits intomicrosoft:masterfrom
jrieken merged 2 commits intomicrosoft:masterfrom
Conversation
Member
|
Don't forget the |
Contributor
Author
@jrieken Oops, sorry for that, Fixed the _saveState function. |
Contributor
Author
|
@jrieken , Did you get some time to review this and also fix a name for the setting ? XD |
Member
|
Looking good. Thanks. I will merge and tweak the name of the setting a little. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@jrieken , here is my initial implementation as per your comments to fix #62365 .
Can you please review this and suggest if anything needs to be changed or added ?
Thanks :)