Option to control actions alignment in search results#63457
Option to control actions alignment in search results#63457roblourens merged 2 commits intomicrosoft:masterfrom
Conversation
roblourens
left a comment
roblourens
left a comment
There was a problem hiding this comment.
Looks great, thanks for the PR! And for cleaning up the CSS 👍
| 'search.actionsPosition': { | ||
| type: 'string', | ||
| enum: ['auto', 'right'], | ||
| default: 'auto', |
There was a problem hiding this comment.
why is this not right?
that would make a ton more sense than auto
There was a problem hiding this comment.
While I personally prefer right I decided to preserve behavior that was default in 1.29 because my issue (filled even before 1.29 release) got 0 👍 and only two supporting comments.
In any way it may be discussed and changed if maintainers are OK with it.
There was a problem hiding this comment.
I've already opened a PR to be address this. Thanks for making this configurable! It's been plaguing me last few days.
There was a problem hiding this comment.
We've discussed this a bunch already, I'm not going to change the default because 'right' doesn't make sense to me for wide views on large monitors. The setting is here for your to customize however you want.
|
This caused #63834 so I will revert it for now. |
|
@joaomoreno thank you for notification. I will submit new PR today. |
4 participants
Fixes #61532
This PR adds new
search.actionsPositionoption that can force search result action (replace, replace all, dismiss) to be always displayed at the right edge of the panel.Other change - count badge for files and folders matches are displayed at the end of match and visible on hover. Only negative aspect of later change is shift of badge in really narrow search block when actions become visible on hover. Since count badge doesn't have click handlers its shift shouldn't be so bad (in comparison with any actionable element).
@roblourens looks like I've removed changes introduces in your commit. Could you please describe what issues this commit fixed or give me a link to the issue. I will check that this PR doesn't regress there.
Also I haven't found test related to search results badge/actions layout etc. Are there tests that I should update in this PR?