Use default terminal colors in debug console and add seperate high-intensity ANSI colors#70969
Use default terminal colors in debug console and add seperate high-intensity ANSI colors#70969iansan5653 wants to merge 2 commits intomicrosoft:masterfrom
Conversation
isidorn
added
the
debug
|
Same as other PR, this is great work. But we will merge in next week fyi @misolori for color changes in the debug console. I think these will be improvments but I am not sure if we need to re-check colors in debug console for contrast ratios for accessibility once we merge this in. |
|
@isidorn I'm actually thinking it would be better to remove the CSS rules altogether and just pull the colors from |
|
@iansan5653 not having that duplicated makes good sense to me. Let's close this PR and wait for the other one. |
2 participants
This updates the default debug console colors to match the default terminal colors found here: https://github.com/Microsoft/vscode/blob/1f64c126721a66f30a7dcc3ac9e605e8115bcca7/src/vs/workbench/contrib/terminal/common/terminalColorRegistry.ts#L40
It also adds separate bright/high-intensity colors to close #63986.
The existing colors have been in place since VSCode was first put on GitHub, but they seem to be pretty arbitrarily chosen. They're muted and hard to read, and they are inconsistent with the rest of the editor.
This is a precursor to a future pull request in which I'll add functionality to update the colors based on the settings made by the current theme per #42388 (I'd still leave this CSS here as defaults though).