Added title case transformation command called 'Transform to Title Case'.#70990
Merged
rebornix merged 4 commits intomicrosoft:masterfrom Mar 29, 2019
jaqra:feature/capitalcase
Merged
Added title case transformation command called 'Transform to Title Case'.#70990rebornix merged 4 commits intomicrosoft:masterfrom jaqra:feature/capitalcase
rebornix merged 4 commits intomicrosoft:masterfrom
jaqra:feature/capitalcase
Conversation
|
|
jaqra
changed the title
Member
|
@jaqra thanks for your contribution! I'd love to call it Transform to Title Case considering that Capital might be confusing FYI
|
jaqra
changed the title
Contributor
Author
|
@rebornix done |
rebornix
requested changes
Mar 28, 2019
| } | ||
|
|
||
| protected _modifyText(text: string): string { | ||
| return text.replace(/\S+/g, function (word: string) { |
Member
There was a problem hiding this comment.
Should we use editor.wordSeparators to split words?
Contributor
Author
There was a problem hiding this comment.
@rebornix well, however should we exclude single quote char?
For ex:
Excluded:
jaqra's commit->Jaqra's Commit✔this is 'single quote char'->This Is 'single Quote Char'❌
Included:
jaqra's commit->Jaqra'S Commit❌this is 'single quote char'->This Is 'Single Quote Char'✔
My brain is burning 🧠🔥
Contributor
Author
There was a problem hiding this comment.
I think we should include (if it exists in word separators)
Contributor
Author
There was a problem hiding this comment.
Is that change acceptable on _modifyText method's parameter?
Here is some results:
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is related to #70858
Before:
After:
