Skip to content

44146 automatically show problems panel#71387

Merged
alexr00 merged 11 commits intomicrosoft:masterfrom
sebastianwitthus:44146-automatically-show-problems-pane
Apr 9, 2019
Merged

44146 automatically show problems panel#71387
alexr00 merged 11 commits intomicrosoft:masterfrom
sebastianwitthus:44146-automatically-show-problems-pane

Conversation

@sebastianwitthus
Copy link
Contributor

@sebastianwitthus sebastianwitthus commented Mar 28, 2019

Issue 44146:

Feature Request

When problems are matched while running a task, I'd like the Problems panel to automatically appear. This is especially useful if I have presentation.reveal set to never.

This branch adds the option revealProblem, which controls whether a task should show the problems panel. Oriented on reveal, it offers always, never and onProblem.
The reveal: silent option already triggers the showing of the terminal when problems of MarkerSeverity Error are encountered. (see terminalTaskSystem.ts ) The hints have been updated to reflect this.

@msftclas
Copy link

msftclas commented Mar 28, 2019 •
edited
Loading

CLA assistant check
All CLA requirements met.

@sebastianwitthus sebastianwitthus mentioned this pull request Mar 29, 2019
Closed
@sebastianwitthus
Copy link
Contributor Author

sebastianwitthus commented Mar 29, 2019

alexr00: To avoid excessive DOM manipulation and/or confusing DOM handling, I no longer fire events for each problemFound (as my first suggestion did) but instead use the end-of-background-processing and end-of-task hooks already provided by the tasks.

@alexr00 alexr00 added this to the April 2019 milestone Apr 3, 2019
alexr00
alexr00 requested changes Apr 8, 2019
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There is a case that doesn't appear to be handled correctly though:

			"presentation": {
				"reveal": "always",
				"revealProblem": "onProblem"
			},

As discussed here this should cause the terminal to show, then the probelm panel to show if a problem occurs.

@sebastianwitthus
Copy link
Contributor Author

sebastianwitthus commented Apr 8, 2019

I'll look into it

@sebastianwitthus
Copy link
Contributor Author

sebastianwitthus commented Apr 8, 2019 •
edited
Loading

@alexr00 I have just confirmed correct behaviour for

"presentation": {
  "reveal": "always",
  "revealProblem": "onProblem"
},

It works with both WatchingProblemCollector and StartStopProblemCollector using tsc -w and tsc, respectively. Have you triggered the WatchingProblemCollector by saving a watched file?

Edit: To clarify, the behaviour is as follows: Start of task opens the 'terminal' panel (non-sticky). End of scan (end of task for tsc, end of scan for tsc -w) closes the terminal panel and opens the 'problem' panel.

alexr00
alexr00 approved these changes Apr 9, 2019
View reviewed changes
Copy link
Member

@alexr00 alexr00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@alexr00
Copy link
Member

alexr00 commented Apr 9, 2019

Thanks for checking that scenario. I was hitting a different issue!

@alexr00 alexr00 merged commit 46bc8cf into microsoft:master Apr 9, 2019
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@alexr00 alexr00 alexr00 approved these changes

Assignees

@alexr00 alexr00

Labels

None yet

Projects

None yet

Milestone

April 2019

Development

Successfully merging this pull request may close these issues.

5 participants

@sebastianwitthus @msftclas @alexr00 @akbyrd @knallfr0sch