Add vscode: URI prefix to knownSchemes in links.ts#71416
Merged
mjbvz merged 2 commits intomicrosoft:masterfrom Apr 2, 2019
Merged
Add vscode: URI prefix to knownSchemes in links.ts#71416mjbvz merged 2 commits intomicrosoft:masterfrom
vscode: URI prefix to knownSchemes in links.ts#71416mjbvz merged 2 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
Well, this fixes the link output issue, but clicking it does not launch the vscode page. |
mjbvz
reviewed
Mar 31, 2019
| import * as vscode from 'vscode'; | ||
|
|
||
| const knownSchemes = ['http:', 'https:', 'file:', 'mailto:', 'data:', 'vscode-resource:']; | ||
| const knownSchemes = ['http:', 'https:', 'file:', 'mailto:', 'data:', 'vscode:', 'vscode-resource:']; |
Collaborator
There was a problem hiding this comment.
Please also add vscode-insiders so insiders links also work
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have not yet built and tested this branch. Should fix #71414.